[PATCH] D51983: [ARM] bottom-top mul support in ARMParallelDSP

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:719
+    auto *OffsetSExt = cast<Instruction>(OffsetLd->user_back());
+    for (Use &U : OffsetSExt->uses()) {
+      auto *Mul = cast<Instruction>(U.getUser());
----------------
Nit: this loop is doing the same things as the previous loop, can we make and call a function?


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:730
+
+    while (OffsetIt != LoopBody->end()) {
+      if (OffsetIt == BaseIt) {
----------------
Nit: looks like this is workaround for not having comparison operators on these iterators. Perhaps we can put this in little helper function too, sweep it under the carpet a little bit, but with a TODO/FIXME and some comments added to it. If a helper function is too much (this function MatchTopBottomMuls is becoming rather big), than at lease some comments here.


https://reviews.llvm.org/D51983