[PATCH] D52162: [XRay] Support for Fuchsia

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_utils.cc:40
+#if SANITIZER_FUCHSIA
+static const char ProfileSinkName[] = "llvm-xray";
+
----------------
mcgrathr wrote:
> I'd use `inline constexpr const char* ProfileSinkName = "llvm-xray";`.
> That makes the string constant mergeable.
compiler-rt uses C++11 but `inline constexpr` is a C++17 construct.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52162