[PATCH] D53264: [ARM64] [Windows] Add unwind support to llvm-readobj

Sanjin Sijaric via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 16 16:53:04 PDT 2018


ssijaric added inline comments.


================
Comment at: tools/llvm-readobj/ARMWinEHPrinter.cpp:836
+    llvm::errs() << "llvm-readobj doesn't yet support COFF unwind info that "
+                    "requires Extended Epilog Count and Extended Code Words.\n";
+    return false;
----------------
ssijaric wrote:
> efriedma wrote:
> > I thought you implemented this...?  At least at first glance, ExceptionDataRecord tries to do the right thing.
> I don't see that this is supported in the current implementation of llvm-readobj.  I don't plan to add it right now.  
> 
> It is supported in the MCLayer part, however.  It needs testing, but is not part of this patch.
It is actually supported, thanks for pointing it out.


Repository:
  rL LLVM

https://reviews.llvm.org/D53264





More information about the llvm-commits mailing list