[PATCH] D50039: [FunctionAttrs] Added nonnull atribute to libc function args
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 16 11:53:07 PDT 2018
efriedma added a comment.
This doesn't look like the patch I was expecting.
Propogating nonnull like this probably makes sense, but this patch should be split into two parts. In the first part, you can extend SimplifyLibCalls to just call `Call->addParamAttr(ArgNo, Attribute::NonNull)` on calls to known library functions, or something like that. Then the second part does the inference from callee to caller; essentially this patch, but looking for nonnull attributes instead of specific libcalls.
https://reviews.llvm.org/D50039
More information about the llvm-commits
mailing list