[PATCH] D53283: AMDGPU: Divergence-driven selection of scalar buffer load intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 16 11:34:56 PDT 2018


arsenm accepted this revision.
arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:3582
+  }
+  MachineOperand *SOff = getNamedOperand(MI, AMDGPU::OpName::soff);
+  if (SOff && !RI.isSGPRClass(MRI.getRegClass(SOff->getReg()))) {
----------------
This should probably be called soffset? I guess that's a preexisting condition


Repository:
  rL LLVM

https://reviews.llvm.org/D53283





More information about the llvm-commits mailing list