[PATCH] D53316: StructurizeCFG: Simplify inserted PHI nodes

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 16 10:57:39 PDT 2018


nhaehnle added inline comments.


================
Comment at: lib/Transforms/Scalar/StructurizeCFG.cpp:650-651
+        Phi->eraseFromParent();
+        InsertedPhis[i] = InsertedPhis.back();
+        InsertedPhis.pop_back();
+        i--;
----------------
arsenm wrote:
> .pop_back_val?
That's incorrect when `i == InsertedPhis.size() - 1`.


Repository:
  rL LLVM

https://reviews.llvm.org/D53316





More information about the llvm-commits mailing list