[PATCH] D53283: AMDGPU: Divergence-driven selection of scalar buffer load intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 16 10:40:52 PDT 2018


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:4824-4827
+  if (VT == MVT::v8i32 || VT == MVT::v16i32) {
+    NumLoads = VT == MVT::v16i32 ? 4 : 2;
+    LoadVT = MVT::v4i32;
+  }
----------------
I don't love the hardcoded types here. Can you assert on the sizes, in case we fix casting all mem operations to int?


Repository:
  rL LLVM

https://reviews.llvm.org/D53283





More information about the llvm-commits mailing list