[PATCH] D53311: [llvm-objcopy] Introduce dispatch mechanism based on input type

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

My first instinct on looking at this is that you are trying to do too many things at once. Could we maybe split it into a few separate reviews, something like:

1. Move ELF-only stuff into a new file, exposing relevant bits as necessary.
2. Add everything required to an elf namespace.
3. Add dispatch mechanism.
4. Add a MachO stub.

It should make it easier to review each step independently, and hopefully try to minimise the number of actual changes mixed in with the move of code.


Repository:
  rL LLVM

https://reviews.llvm.org/D53311