[PATCH] D53254: [Merge SImilar Function ThinLTO 5/n] Set up similar function to be imported

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:519
+            auto FS = cast<FunctionSummary>(S);
+            // TODO: Import declarations of global variables as well.
+            if (FS->refs().size())
----------------
hiraditya wrote:
> tejohnson wrote:
> > Why this constraint? Note that any global variables being referenced by an imported function will automatically have their declarations imported too.
> I'll remove this comment. Does not seem to be relevant.
It isn't just the comment, but also the corresponding check just below that the refs() be empty.


https://reviews.llvm.org/D53254