[PATCH] D31068: [SDAG] Expand MergedConsecutiveStores to better handle Giving up in Chain Analysis

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12413
+  StoreSDNode *STChain = St;
+  int64_t LastOffset = BasePtr.Offset;
+  while (StoreSDNode *Chain = dyn_cast<StoreSDNode>(STChain->getChain())) {
----------------
Please rebase, you'll have to go through `CandidateMatch`'s `Offset` parameter now.


================
Comment at: test/CodeGen/X86/stores-merging2.ll:16
+; CHECK-LABEL: @foo
+; CHECK: movl	$1684234849, strpt
+
----------------
This test fails to fail before this change when rebased on master. I guess this is because the value of GatherAllAliasesMaxDepth has been changed from 6 to 18.

The test quite brittle against that kind of config changes BTW. You should at least leave a comment for the future explaining how to fix the test if changing the value.


https://reviews.llvm.org/D31068