[PATCH] D53222: AMDGPU: Add sram-ecc feature

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

Mostly looks good to me, but I do have some questions / comments.



================
Comment at: docs/AMDGPUUsage.rst:263
+                     feature disabled.
+     -m[no-]sram-ecc Enable/disable SRAM ECC.
+     =============== ==================================================
----------------
Maybe better:

> Enable/disable compiling code that can run with SRAM ECC enabled.

After all, this option doesn't actually enable the ECC itself, it just makes sure to generate code that works with ECC is enabled. I think we should also mention that code compiled with -msram-ecc will be able to run both with and without ECC.




================
Comment at: docs/AMDGPUUsage.rst:550
                                                   :ref:`amdgpu-target-features`.
+     ``EF_AMDGPU_SRAM_ECC``            0x00001000 Indicates if the ``sram-ecc``
+                                                  target feature is
----------------
Why not 0x200?


https://reviews.llvm.org/D53222