[PATCH] D53234: Don't remove COMDATs when internalizing global objects

[Aaron Hill via Phabricator via llvm-commits]

Aaron1011 added a comment.

> Normally once they are both internalized and removed from the comdat, it shouldn't matter if only one is kept by GlobalDCE. The other is simply an internal function and no longer part of a comdat (so it's not like the comdat is incomplete).

My understanding is that deleting the COMDAT is invalid. The LLVM Language Reference <https://llvm.org/docs/LangRef.html#comdats> doesn't mention anything about removing COMDATS during LTO.
>From that perspective, the dangling !associated metadata is simply a consequence of the underlying issue of the COMDAT removal.


https://reviews.llvm.org/D53234