[PATCH] D53155: [DWARF] Make llvm-dwarfdump display location lists in a .dwp file correctly. Fixes PR38990.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 15 12:31:41 PDT 2018
dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.
================
Comment at: include/llvm/DebugInfo/DWARF/DWARFUnit.h:203
+ /// refer to substrings of it when opportune (e.g. in a DWARF package file).
+ std::pair<const DWARFSection *, StringRef> LocSection;
const DWARFSection &LineSection;
----------------
wolfgangp wrote:
> dblaikie wrote:
> > Could this be a union, perhaps?
> Yes, that's better. I guess we can't use std::variant yet?
I don't think so, unfortunately :/
https://reviews.llvm.org/D53155
More information about the llvm-commits
mailing list