[PATCH] D52961: [RISCV] Introduce the RISCVMatInt::generateInstSeq helper
Sameer AbuAsal via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 15 11:58:52 PDT 2018
sabuasal added a comment.
In https://reviews.llvm.org/D52961#1265204, @asb wrote:
> In https://reviews.llvm.org/D52961#1261196, @sabuasal wrote:
>
> > In https://reviews.llvm.org/D52961#1258464, @asb wrote:
> >
> > > No real reason to prefer one or the other when they're semantically identical. It's mostly to be closer to gas/gcc which uses addi at least for the isInt<12> case.
> >
> >
> > I see. makes sense. I just checked gcc and it seems to be favoring addi for that case.
>
>
> Does this look good to you then?
Yes, no more comments on my side.
https://reviews.llvm.org/D52961
More information about the llvm-commits
mailing list