[PATCH] D53267: [CodeExtractor] Erase debug intrinsics in outlined thunks

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 15 11:15:39 PDT 2018


vsk added a comment.

In https://reviews.llvm.org/D53267#1265641, @sebpop wrote:

> Does this patch fix https://bugs.llvm.org/show_bug.cgi?id=22900 
>  In which case you may want to add the testcases from that bug.


It does. I'm not sure that there's extra value in including the attached test case -- it uses an old textual IR format that's hard to update, and reduces to something similar to the test in this patch.

Fwiw I've tested this patch by building several internal frameworks and running Csmith over the weekend. I found no regressions. With Csmith, the testing method was to run `-Os -g -mllvm -hot-cold-split={true, false}` and check that the two CRCs were the same.


https://reviews.llvm.org/D53267





More information about the llvm-commits mailing list