[PATCH] D53254: [Merge SImilar Function ThinLTO 5/n] Set up similar function to be imported

[Brian Rzycki via Phabricator via llvm-commits]

brzycki added a comment.

Hi @hiraditya , comments inline.



================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:488
+  // TODO: Make hashing little more strict to have higher hit rate
+  auto &HostSimilarFunctions = Index.getHostSimilarFunction();
+  if (HostSimilarFunctions.empty())
----------------
ooh boy this is a dense section of code. Possibly consider refactoring into helper functions for readability?


https://reviews.llvm.org/D53254