[PATCH] D53253: [Merge SImilar Function ThinLTO 4/n] Make merge function decisions before the thin-lto stage

[Brian Rzycki via Phabricator via llvm-commits]

brzycki added a comment.

Hi @hiraditya , comments inline.



================
Comment at: lib/Transforms/IPO/MergeSimilarFunctions.cpp:1327
+  // Shouldn't have entries with hash of 0, because those are placeholders.
+  assert(!SimFunctions.count(0));
+  auto &HostSimFunction = Index.getHostSimilarFunction();
----------------
Possibly convert this and the previous line to:
```
assert(!SimFunctions.count(0) && "Zero hash entries are placeholders");
```


https://reviews.llvm.org/D53253