[PATCH] D52947: [globalisel][combiner] Make the CombinerChangeObserver a MachineFunction::Delegate

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/CombinerHelper.h:38
+  void replaceRegWith(MachineRegisterInfo &MRI, unsigned FromReg, unsigned ToReg) const;
+
   /// If \p MI is COPY, try to combine it.
----------------
Also, should replaceRegWith respect register constraints (such as RegBank/RegClass) and emit copies while replacing?


Repository:
  rL LLVM

https://reviews.llvm.org/D52947