[PATCH] D53270: [NewPM] implement SCC printing for -print-before-all/-print-after-all

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added inline comments.


================
Comment at: lib/Passes/StandardInstrumentations.cpp:40
 void unwrapAndPrint(StringRef Banner, Any IR) {
-  if (any_isa<const CallGraphSCC *>(IR) ||
-      any_isa<const LazyCallGraph::SCC *>(IR))
----------------
what about CallGraphSCC?
I seen an implementation for LazyCakkGraph but do not see for CallGraphSCC?


================
Comment at: lib/Passes/StandardInstrumentations.cpp:61
+      for (const LazyCallGraph::Node &N : *C) {
+	const Function& F = N.getFunction();
+	if (!F.isDeclaration() && isFunctionInPrintList(F.getName())) {
----------------
indent


================
Comment at: lib/Passes/StandardInstrumentations.cpp:76
+	M = F.getParent();
+    }
+    if (!M)
----------------
break;


Repository:
  rL LLVM

https://reviews.llvm.org/D53270