[PATCH] D53247: [ADT] Add initializer_list constructor, equality tests for DenseMap/DenseSet.

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 14 14:02:55 PDT 2018


lhames updated this revision to Diff 169630.
lhames added a comment.

Updated to remove the dependence on stable iteration order for operator== (on both DenseMap and DenseSet). Also adds some comments on performance.

I decided to leave the initializer_list constructor for DenseMap in this patch, as it simplifies unit testing: The equality operators are the easiest way to test that DenseMap construction behaved as expected and vice-versa.


Repository:
  rL LLVM

https://reviews.llvm.org/D53247

Files:
  ADT/DenseMapTest.cpp
  ADT/DenseSetTest.cpp
  llvm/ADT/DenseMap.h
  llvm/ADT/DenseSet.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53247.169630.patch
Type: text/x-patch
Size: 5201 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181014/8c619f76/attachment.bin>


More information about the llvm-commits mailing list