[PATCH] D53205: [FPEnv][NFCI] Convert more BinaryOperator::isFNeg(...) to m_FNeg(...)

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally marked 2 inline comments as done.
cameron.mcinally added a comment.

In https://reviews.llvm.org/D53205#1264508, @spatel wrote:

> I suspect that none of these changes are actually 'NFC'.


Yes, I agree with that. The test case you added for https://reviews.llvm.org/D52934 shows there was a *seemingly* positive change.

I don't have a lot of intuition built up around this code, but will add test cases where I see differences...



================
Comment at: lib/Transforms/InstCombine/InstCombineInternal.h:87
+        match(V, m_FNeg(m_Value())) || BinaryOperator::isNot(V))
       return 4;
     return 5;
----------------
spatel wrote:
> cameron.mcinally wrote:
> > @spatel, have you given any thought to replacing the integer isNeg (and friends) BinaryOperator helper functions with pattern matcher functions? It will help keep the code more uniform. Just thinking aloud...
> Yes, we should get rid of the integer binop helpers as part of the fneg cleanup.
It looks like you handled this in rL344458. Thanks for that.


Repository:
  rL LLVM

https://reviews.llvm.org/D53205