[PATCH] D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops.

[Dinar Temirbulatov via Phabricator via llvm-commits]

dtemirbulatov updated this revision to Diff 169574.
dtemirbulatov added a comment.

Update after I found another couple of errors after additional testing the change. Here are changes:
Removed OpValue field out of PseudoScheduleData.
Forbid any bundles with non-alternative operations and remainder operation, see rem-bundle.ll.
Fixed error in setInsertPointAfterBundle() function by using getScheduleData() instead of getInstrScheduleData and if a bundle member is present multiple bundles at the same time then walk through the bundle to find the last scheduled member of the bundle.  see insert-after-multiple-bundle.ll
Restore MemoryDependencies to SmallVector, we don't have to count a member presents in calculateDependencies().


https://reviews.llvm.org/D28907

Files:
  lib/Transforms/Vectorize/SLPVectorizer.cpp
  test/Transforms/SLPVectorizer/X86/cancel_scheduling.ll
  test/Transforms/SLPVectorizer/X86/insert-after-multiple-bundle.ll
  test/Transforms/SLPVectorizer/X86/memory-dep.ll
  test/Transforms/SLPVectorizer/X86/pr35497.ll
  test/Transforms/SLPVectorizer/X86/rem-bundle.ll
  test/Transforms/SLPVectorizer/X86/vect_copyable_in_binops.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28907.169574.patch
Type: text/x-patch
Size: 131470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181013/e8bfc63d/attachment-0001.bin>