[PATCH] D53245: Teach the DominatorTree fallback to recalculation when applying updates to speedup JT (PR37929)

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 13 08:35:12 PDT 2018


kuhar added a comment.

Thanks for looking into this. A couple of high-level questions:

- how was the constant "650" picked? Is it just playing with different values and choosing something that seemed reasonable?
- why is the threshold independent of the tree size? Intuitively the policy could be to recalculate if the number of updates is greater than some multiple of size. Maybe we can refer to the average-case complexity from Lucuas' paper?
- why do we want to put it in the incremental updater instead of the DomTreeUpdater class?


Repository:
  rL LLVM

https://reviews.llvm.org/D53245





More information about the llvm-commits mailing list