[PATCH] D53162: [DataLayout] Add bit width of pointers to global values

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 12 14:23:46 PDT 2018


efriedma added a comment.

I'm not sure it makes sense to put this information in the DataLayout.

The number of bits required to represent the address of a global isn't really a fundamental aspect of the target; it can vary based on the code generation options used.  For example, on x86-64, non-position-independent code can assume the address of a global fits into 32 bits, but we don't want to change the datalayout based on whether the user passed -fPIC.  And even if it is fundamental on some targets, it doesn't seem important enough to include in the datalayout; no target-independent transforms care about known bits for pointers beyond figuring out the alignment of a pointer.


Repository:
  rL LLVM

https://reviews.llvm.org/D53162





More information about the llvm-commits mailing list