[PATCH] D53148: [X86][AVX] Add lowerVectorShuffleAsLanePermuteAndPermute for v4f64 shuffles (PR39161)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 12 13:29:11 PDT 2018


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:13445
+  SmallVector<int, 4> SrcLaneMask(NumLanes, SM_SentinelUndef);
+  SmallVector<int, 4> LaneMask(NumElts, SM_SentinelUndef);
+  SmallVector<int, 16> PermMask(NumElts, SM_SentinelUndef);
----------------
craig.topper wrote:
> Why do LaneMask and PermMask have the same actual size, but different "small" size?
copy+paste has failed me again....


Repository:
  rL LLVM

https://reviews.llvm.org/D53148





More information about the llvm-commits mailing list