[PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

The bots are now failing because lexists doesn't handle NoneType correctly:

    File "/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/packages/Python/lldbsuite/test/configuration.py", line 191, in get_filecheck_path
      if os.path.lexists(filecheck):
    File "/lldb-buildbot/virenv/lib/python2.7/posixpath.py", line 152, in lexists
      os.lstat(path)
  TypeError: coercing to Unicode: need string or buffer, NoneType found

I think get_filecheck_path should check if filecheck is set first before calling lexists:

  if filecheck and os.path.lexists(filecheck):
          return filecheck


Repository:
  rL LLVM

https://reviews.llvm.org/D53175