[PATCH] D53001: [Driver] check for exit code from SIGPIPE
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 12 12:39:10 PDT 2018
nickdesaulniers marked an inline comment as done.
nickdesaulniers added inline comments.
================
Comment at: cfe/trunk/lib/Driver/Driver.cpp:81-85
+#include <sysexits.h>
#include <utility>
#if LLVM_ON_UNIX
#include <unistd.h> // getpid
#endif
----------------
nickdesaulniers wrote:
> @rnk || @majnemer thoughts on making this:
>
> ```
> #if LLVM_ON_UNIX
> #include <unistd.h> // getpid
> #include <sysexits.h> // EX_IOERR
> #else
> #define EX_IOERR 74
> #endif
> ```
>
> vs also guarding the check I added on L1409 with `#if LLVM_ON_UNIX`?
posted to: https://reviews.llvm.org/D53210
(let's do code review there).
Repository:
rL LLVM
https://reviews.llvm.org/D53001
More information about the llvm-commits
mailing list