[PATCH] D53205: [FPEnv][NFCI] Convert more BinaryOperator::isFNeg(...) to m_FNeg(...)

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 12 09:57:05 PDT 2018


cameron.mcinally added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineInternal.h:87
+        match(V, m_FNeg(m_Value())) || BinaryOperator::isNot(V))
       return 4;
     return 5;
----------------
@spatel, have you given any thought to replacing the integer isNeg (and friends) BinaryOperator helper functions with pattern matcher functions? It will help keep the code more uniform. Just thinking aloud...


Repository:
  rL LLVM

https://reviews.llvm.org/D53205





More information about the llvm-commits mailing list