[PATCH] D53204: [ELF] [HEXAGON] Let input determine ELF header e_flags

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 12 09:52:25 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/Arch/Hexagon.cpp:59
+static uint32_t getEFlags(InputFile *F) {
+  return cast<ObjFile<ELF32LE>>(F)->getObj().getHeader()->e_flags;
+}
----------------
I don't think you need to define this function -- you can just inline.


================
Comment at: ELF/Arch/Hexagon.cpp:73
+  }
+  return Target;
+}
----------------
`Target` is a bit weird name. Maybe just `Ret`.



Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53204





More information about the llvm-commits mailing list