[PATCH] D52951: [lld] Add more complete support for the INCLUDE command.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 12 01:59:04 PDT 2018
grimar accepted this revision.
grimar added a comment.
LGTM with a minor nit.
================
Comment at: test/ELF/linkerscript/section-include.test:11
+# RUN: llvm-objdump -section-headers %t.elf | FileCheck %s --check-prefix=CHECK1
+# CHECK1: .data 00000008 0000000000002000 DATA
+# CHECK1-NEXT: .data3 00000008 0000000000002008 DATA
----------------
Please align this:
```
# CHECK1: .data 00000008 0000000000002000 DATA
# CHECK1-NEXT: .data3 00000008 0000000000002008 DATA
```
================
Comment at: test/ELF/linkerscript/section-include.test:18
+# RUN: llvm-objdump -section-headers %t.elf | FileCheck %s --check-prefix=CHECK2
+# CHECK2: .data 00000008 0000000000002000 DATA
+# CHECK2-NEXT: .data2 00000008 0000000000002008 DATA
----------------
And this.
https://reviews.llvm.org/D52951
More information about the llvm-commits
mailing list