[llvm] r344326 - [mips] Mark fmaxl as a long double emulation routine
Stefan Maksimovic via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 12 01:18:38 PDT 2018
Author: smaksimovic
Date: Fri Oct 12 01:18:38 2018
New Revision: 344326
URL: http://llvm.org/viewvc/llvm-project?rev=344326&view=rev
Log:
[mips] Mark fmaxl as a long double emulation routine
Failure was discovered upon running
projects/compiler-rt/test/builtins/Unit/divtc3_test.c
in a stage2 compiler build.
When compiling projects/compiler-rt/lib/builtins/divtc3.c,
a call to fmaxl within the divtc3 implementation had its
return values read from registers $2 and $3 instead of $f0 and $f2.
Include fmaxl in the list of long double emulation routines
to have its return value correctly interpreted as f128.
Almost exact issue here: https://reviews.llvm.org/D17760
Differential Revision: https://reviews.llvm.org/D52649
Added:
llvm/trunk/test/CodeGen/Mips/cconv/fmaxl_call.ll
Modified:
llvm/trunk/lib/Target/Mips/MipsCCState.cpp
Modified: llvm/trunk/lib/Target/Mips/MipsCCState.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsCCState.cpp?rev=344326&r1=344325&r2=344326&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/MipsCCState.cpp (original)
+++ llvm/trunk/lib/Target/Mips/MipsCCState.cpp Fri Oct 12 01:18:38 2018
@@ -24,10 +24,10 @@ static bool isF128SoftLibCall(const char
"__lttf2", "__multf3", "__netf2", "__powitf2",
"__subtf3", "__trunctfdf2", "__trunctfsf2", "__unordtf2",
"ceill", "copysignl", "cosl", "exp2l",
- "expl", "floorl", "fmal", "fmodl",
- "log10l", "log2l", "logl", "nearbyintl",
- "powl", "rintl", "roundl", "sinl",
- "sqrtl", "truncl"};
+ "expl", "floorl", "fmal", "fmaxl",
+ "fmodl", "log10l", "log2l", "logl",
+ "nearbyintl", "powl", "rintl", "roundl",
+ "sinl", "sqrtl", "truncl"};
// Check that LibCalls is sorted alphabetically.
auto Comp = [](const char *S1, const char *S2) { return strcmp(S1, S2) < 0; };
Added: llvm/trunk/test/CodeGen/Mips/cconv/fmaxl_call.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/cconv/fmaxl_call.ll?rev=344326&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/Mips/cconv/fmaxl_call.ll (added)
+++ llvm/trunk/test/CodeGen/Mips/cconv/fmaxl_call.ll Fri Oct 12 01:18:38 2018
@@ -0,0 +1,25 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=mips64el-unknown-linux-gnu -mcpu=mips64 < %s | FileCheck %s
+
+define fp128 @call_fmaxl(fp128 %a, fp128 %b) {
+; CHECK-LABEL: call_fmaxl:
+; CHECK: # %bb.0:
+; CHECK-NEXT: daddiu $sp, $sp, -16
+; CHECK-NEXT: .cfi_def_cfa_offset 16
+; CHECK-NEXT: sd $ra, 8($sp) # 8-byte Folded Spill
+; CHECK-NEXT: .cfi_offset 31, -8
+; CHECK-NEXT: jal fmaxl
+; CHECK-NEXT: nop
+; CHECK-NEXT: mov.d $f12, $f0
+; CHECK-NEXT: jal f
+; CHECK-NEXT: mov.d $f13, $f2
+; CHECK-NEXT: ld $ra, 8($sp) # 8-byte Folded Reload
+; CHECK-NEXT: jr $ra
+; CHECK-NEXT: daddiu $sp, $sp, 16
+ %1 = call fp128 @llvm.maxnum.f128(fp128 %a, fp128 %b)
+ %2 = call fp128 @f(fp128 %1)
+ ret fp128 %2
+}
+
+declare fp128 @llvm.maxnum.f128(fp128, fp128)
+declare fp128 @f(fp128)
More information about the llvm-commits
mailing list