[PATCH] D53183: Fix bug where `config.asan_dynamic` in generated ASan `lit.site.cfg` files was set to `False` for macOS. It should actually be `True` because dylibs are the only supported form of the ASan runtime on Apple platforms.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 11 18:49:25 PDT 2018


delcypher created this revision.
delcypher added reviewers: kubamracek, george.karpenkov, samsonov.
Herald added subscribers: Sanitizers, mgorny, srhines.

Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D53183

Files:
  test/asan/CMakeLists.txt


Index: test/asan/CMakeLists.txt
===================================================================
--- test/asan/CMakeLists.txt
+++ test/asan/CMakeLists.txt
@@ -56,7 +56,7 @@
   string(TOLOWER "-${arch}-${OS_NAME}" ASAN_TEST_CONFIG_SUFFIX)
   get_bits_for_arch(${arch} ASAN_TEST_BITS)
   get_test_cc_for_arch(${arch} ASAN_TEST_TARGET_CC ASAN_TEST_TARGET_CFLAGS)
-  if(ANDROID)
+  if(ANDROID OR APPLE)
     set(ASAN_TEST_DYNAMIC True)
   else()
     set(ASAN_TEST_DYNAMIC False)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53183.169347.patch
Type: text/x-patch
Size: 479 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181012/c8fe1fbf/attachment.bin>


More information about the llvm-commits mailing list