[PATCH] D52992: cxa_demangle: make demangler's parsing functions overridable

[Erik Pilkington via Phabricator via llvm-commits]

erik.pilkington added a comment.

Thanks for doing this!



================
Comment at: src/demangle/ItaniumDemangle.h:2214
+template <typename Derived, typename Alloc = DefaultAllocator>
+struct AbstractDb {
   const char *First;
----------------
rsmith wrote:
> If you're going to do a mass rename on this class anyway, have you considered giving it a more reasonable name (maybe something like `ManglingParser`)?
Yep, I agree. Db is a really horrible name for this.


================
Comment at: src/demangle/ItaniumDemangle.h:2246
 
-  Db(const char *First_, const char *Last_) : First(First_), Last(Last_) {}
+  AbstractDb(const char* First_, const char* Last_)
+      : First(First_), Last(Last_) {}
----------------
I think libcxxabi's clang-format moved all the pointers to the left. I just committed r344316, which overrides libcxxabi's behaviour for this directory. Can you re-run this through clang-format-diff?


Repository:
  rCXXA libc++abi

https://reviews.llvm.org/D52992