[PATCH] D52999: [FileCheck] Annotate input dump
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 11 15:34:23 PDT 2018
jdenny updated this revision to Diff 169320.
jdenny edited the summary of this revision.
jdenny added a comment.
Address reviewer concerns:
- Add examples of match result types.
- Document space that follows an input line number.
- Clarify input file vs. check file for line numbers.
- "when no match" -> "when no match is found".
- Don't abbreviate directive types.
That's everything I know to do for now.
https://reviews.llvm.org/D52999
Files:
llvm/docs/CommandGuide/FileCheck.rst
llvm/include/llvm/Support/FileCheck.h
llvm/include/llvm/Support/WithColor.h
llvm/lib/Support/FileCheck.cpp
llvm/test/FileCheck/dump-input-annotations.txt
llvm/test/FileCheck/dump-input-enable.txt
llvm/test/FileCheck/match-full-lines.txt
llvm/test/FileCheck/verbose_mode.txt
llvm/utils/FileCheck/FileCheck.cpp
llvm/utils/lit/lit/TestingConfig.py
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52999.169320.patch
Type: text/x-patch
Size: 64209 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181011/0ea50881/attachment.bin>
More information about the llvm-commits
mailing list