[PATCH] D53173: [X86] Type legalize v2f32 stores by widening to v4f32, casting to v2f64, extracting f64 and storing.
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 11 14:57:23 PDT 2018
craig.topper added inline comments.
================
Comment at: test/CodeGen/X86/2012-01-18-vbitcast.ll:10
; CHECK-NEXT: .seh_endprologue
+; CHECK-NEXT: movsd {{.*#+}} xmm0 = mem[0],zero
+; CHECK-NEXT: movsd %xmm0, (%rsp)
----------------
Something odd happened here. Suspect something to do with how bitcasts from 2 x float to 2 x i32 are legalized. v2f32 is widened but v2i32 is promoted. Generic legalization probably went through the stack Can probably fix with a custom legalization of this bitcast.
================
Comment at: test/CodeGen/X86/fold-load-vec.ll:17
; CHECK-NEXT: movlps %xmm0, (%rsp)
-; CHECK-NEXT: movlps %xmm0, (%rsi)
+; CHECK-NEXT: movq (%rsp), %rax
+; CHECK-NEXT: movq %rax, (%rsi)
----------------
Need to investigate
https://reviews.llvm.org/D53173
More information about the llvm-commits
mailing list