[PATCH] D53165: [WebAssembly] Add Defs = [ARGUMENTS] to SIMD_I

[Heejin Ahn via Phabricator via llvm-commits]

aheejin created this revision.
aheejin added a reviewer: tlively.
Herald added subscribers: llvm-commits, sunfish, jgravelle-google, sbc100, dschuff.

https://reviews.llvm.org/rL344086 seems to have deleted it, and https://reviews.llvm.org/rL344180 tried to solve it by
adding `Defs = [ARGUMENTS]`, which somehow broke the expensive check
bot. This patch adds this to `SIMD_I` as a temporary measure until we
land https://reviews.llvm.org/rL344180 again.


Repository:
  rL LLVM

https://reviews.llvm.org/D53165

Files:
  lib/Target/WebAssembly/WebAssemblyInstrSIMD.td


Index: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
===================================================================
--- lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
+++ lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
@@ -16,6 +16,7 @@
 multiclass SIMD_I<dag oops_r, dag iops_r, dag oops_s, dag iops_s,
                   list<dag> pattern_r, string asmstr_r = "",
                   string asmstr_s = "", bits<32> simdop = -1> {
+  let Defs = [ARGUMENTS] in
   defm "" : I<oops_r, iops_r, oops_s, iops_s, pattern_r, asmstr_r, asmstr_s,
               !or(0xfd00, !and(0xff, simdop))>,
             Requires<[HasSIMD128]>;
@@ -55,7 +56,6 @@
                                   "v128.const\t"#args, 0>;
 }
 
-let Defs = [ARGUMENTS] in {
 defm "" : ConstVec<v16i8,
                    (ins vec_i8imm_op:$i0, vec_i8imm_op:$i1,
                         vec_i8imm_op:$i2, vec_i8imm_op:$i3,
@@ -100,7 +100,6 @@
                   (ins f64imm_op:$i0, f64imm_op:$i1),
                   (build_vector (f64 fpimm:$i0), (f64 fpimm:$i1)),
                   "$i0, $i1">;
-} // Defs = [ARGUMENTS]
 
 // Create vector with identical lanes: splat
 def splat2 : PatFrag<(ops node:$x), (build_vector node:$x, node:$x)>;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53165.169289.patch
Type: text/x-patch
Size: 1209 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181011/cc2dfbaa/attachment.bin>