[PATCH] D52836: [LTO] Account for overriding lib calls via the alias attribute

[Eric Liu via llvm-commits]

Hi Warren, I'm also hitting the same error in our internal test with
optimized build. Would you mind relaxing the checks as you described?
Thanks!

On Thu, Oct 11, 2018 at 8:01 PM Warren Ristow via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> wristow added a comment.
>
> In https://reviews.llvm.org/D52836#1262070, @MaskRay wrote:
>
> > However, the function argument uses an implicit label `%0`, causing
> failure of `LTO/X86/libcall-overridden-via-alias.ll`
> >
> >   ; Function Attrs: norecurse nounwind readnone
> >   define internal float @logf(float) #2 {
> >     %2 = fadd float %0, %0
> >     ret float %2
> >   }
> >
>
>
> I'm not seeing the implicit `%0` in local runs, so I'm not seeing this
> failure.  And searching on the bots I couldn't find it either.  What I see
> in my local runs is an explicit parameter `%x`:
>
>   ; Function Attrs: norecurse nounwind readnone
>   define internal float @logf(float %x) #2 {
>     %add = fadd float %x, %x
>     ret float %add
>   }
>
> I can change the test to just look for an `fadd` followed by the `ret`
> (and so just not verify that the `fadd` is adding the formal arg to itself,
> which isn't critical), but I'm puzzled as to how this is happening.  Can
> you let me know which bot is failing?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D52836
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181011/17d684ba/attachment.html>