[PATCH] D53098: [InstCombine] Avoid instruction sinking if not profitable for other passes

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 11 12:11:44 PDT 2018


xbolva00 added a comment.

I will precommit them if folks say this is fine direction to go.

If we sink the call instructions, Florian's new SCCP patches related to null checks optimizations are unable to benefit from the dominating call with nonnull args.

Florian disabled sinking to see the potential of his new SCCP optimizations, but we need a stronger solution (to not regress in other areas).


https://reviews.llvm.org/D53098





More information about the llvm-commits mailing list