[PATCH] D53134: [tblgen][llvm-mca] Add the ability to describe move elimination candidates via tablegen.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added inline comments.


================
Comment at: include/llvm/CodeGen/TargetSubtargetInfo.h:176
+  /// stage. Subtargets can specify the set of optimizable moves by
+  /// instantiating tablegen class `IsOptimizableMoveFunction` (see
+  /// llvm/Target/TargetInstrPredicate.td).
----------------
RKSimon wrote:
> Any reason why we don't reuse the name isOptimizableRegisterMove?
No reason... I am happy to change the name of that class to "IsOptimizableRegisterMove".


================
Comment at: include/llvm/Target/TargetSchedule.td:463
 //  - The cost of a register rename.
+//  - The set of registers that allow move elimination
+//  - The maximum number of moves that can be eliminated every cycle.
----------------
mattd wrote:
> nit: Add a period to the end of this line. 
Will do.


================
Comment at: include/llvm/Target/TargetSchedule.td:515
+// Field MaxMovesEliminatedPerCycle specifies how many moves can be eliminated
+// every cycle. A default value of zero for that field means: ther is no limit
+// to the number of moves that can be eliminated by this register file.
----------------
mattd wrote:
> s/ther/there/
Will do.


================
Comment at: include/llvm/Target/TargetSchedule.td:527
+// A register move MI is eliminated only if:
+//  - MI is a move elimination candidate
+//  - The destination register is from a register class that allows move
----------------
mattd wrote:
> nit: Add a period to the end of this line. 
Will do.


https://reviews.llvm.org/D53134