[PATCH] D53139: [ThinLTO] Don't import GV which contains blockaddress

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 11 10:48:47 PDT 2018


evgeny777 updated this revision to Diff 169246.
evgeny777 added a comment.

> Are those ever expected to reference a blockaddress?

Yes, they are. But instruction in any given function can only reference basic block in the same function. 
So we're not interested in return value of `findRefEdges`. I've reflected this in a comment to `findRefEdges`


https://reviews.llvm.org/D53139

Files:
  lib/Analysis/ModuleSummaryAnalysis.cpp
  lib/Transforms/IPO/FunctionImport.cpp
  test/ThinLTO/X86/Inputs/globals-import-blockaddr.ll
  test/ThinLTO/X86/globals-import-blockaddr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53139.169246.patch
Type: text/x-patch
Size: 4978 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181011/c285bb89/attachment.bin>


More information about the llvm-commits mailing list