[PATCH] D52836: [LTO] Account for overriding lib calls via the alias attribute

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 11 09:42:40 PDT 2018


MaskRay added a comment.

The check lines are:

  ; Check that the IR contains the overriding definition of the library routine
  ; in the IR after LTO:
  ; CHECK_IR: define internal float @logf(float [[X:%.*]])
  ; CHECK_IR-NEXT:   [[TMP:%.*]] = fadd float [[X]], [[X]]
  ; CHECK_IR-NEXT:   ret float [[TMP]]

However, the function argument uses an implicit label `%0`, causing failure of `LTO/X86/libcall-overridden-via-alias.ll`

  ; Function Attrs: norecurse nounwind readnone
  define internal float @logf(float) #2 {
    %2 = fadd float %0, %0
    ret float %2
  }


Repository:
  rL LLVM

https://reviews.llvm.org/D52836





More information about the llvm-commits mailing list