[PATCH] D53130: [DebugInfo][LCSSA] Rewrite pre-existing debug values outside loop

[Matt Davis via Phabricator via llvm-commits]

mattd added a comment.

This LGTM, but I'd wait to see what others say.



================
Comment at: lib/Transforms/Utils/LCSSA.cpp:117
 
+    SmallVector<DbgValueInst *, 4> DbgValues;
+    llvm::findDbgValues(DbgValues, I);
----------------
Can we move this container and accompanying findDbgValue call closer to where it's used, around line 208, or is it necessary that we get the debug value early before we create the new PHIs?


Repository:
  rL LLVM

https://reviews.llvm.org/D53130