[PATCH] D46423: [WIP, RISCV] Support .option relax and .option norelax

[Nirav Dave via Phabricator via llvm-commits]

niravd added a comment.

In https://reviews.llvm.org/D46423#1261724, @asb wrote:

> Shiva and Kito didn't seem to have any concerns so I was just re-checking prior to committing. I had a closer look at getAssemblerPtr and see this method was introduced by @niravd in https://reviews.llvm.org/rL331218. Nirav - are you happy for this patch to change getAssemblerPtr so it doesn't just return `nullptr` in MCStreamer.h? I don't think gating on UseAssemblerInfoForParsing makes sense in our case.


No.

Disabling assembler-level information for parsing in the MCAsmStreamer was a compromise we reached for enforcing some consistency on assembler-dependent parsing to text and that relies on getAssemblerPtr() being nullptr, so it's not okay. (We should probably add a comment to that effect in MCAsmStreamer).

That said, it looks like the only reason this is coming up because you're using getAssemblerPtr() to access the backend. You should be able to leave getAssemblerPtr() as is and just use getAssembler() instead.


Repository:
  rL LLVM

https://reviews.llvm.org/D46423