[PATCH] D52961: [RISCV] Introduce the RISCVMatInt::generateInstSeq helper

[Mario Werner via Phabricator via llvm-commits]

niosHD added a comment.

For me the patch looks good, thank you for working on it Alex!

I like using `ADDI` instead of `ADDIW` when possible to get more consistent codegen output. However, the comment should be updated to reflect this change.



================
Comment at: lib/Target/RISCV/Utils/RISCVMatInt.cpp:26
+    // v == 0                        : ADDI(W)
+    // v[0,12) != 0 && v[12,32) == 0 : ADDI(W)
+    // v[0,12) == 0 && v[12,32) != 0 : LUI
----------------
The comment should be updated to reflect that we now always emit ADDI in the first two cases.


https://reviews.llvm.org/D52961