[PATCH] D53103: Support for the mno-tls-direct-seg-refs flag

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

Looks good to me. Craig should probably sign off too though.



================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:168
 
+    /// Disable direct TLS access through segment registers
+    bool IndirectTlsSegRefs;
----------------
nit: period at the end.


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:987
     if (C->getSExtValue() == 0 && AM.Segment.getNode() == nullptr &&
+        !IndirectTlsSegRefs &&
         (Subtarget->isTargetGlibc() || Subtarget->isTargetAndroid() ||
----------------
Looks very simple :-) I'm not really familiar with this, but I assume you've tested that it does the right thing.


================
Comment at: test/CodeGen/X86/tls.ll:457
+
+define i32 @f17() #0 {
+; X86_LINUX-LABEL: f17:
----------------
I know this file seems to go for brevity of function names, but I'd still suggest calling it something more descriptive, or adding a comment so it's more obvious to the reader what's going on.


Repository:
  rL LLVM

https://reviews.llvm.org/D53103