[PATCH] D52304: [X86][BMI1]: X86DAGToDAGISel: select BEXTR from x & ~(-1 << nbits) pattern

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D52304#1261531, @craig.topper wrote:

> LGTM


Thank you for the review!

We will now have a duplicating matchers in the tablegen, and here, for these patterns.
What do you think about also matching the BZHI here, and dropping the tablegen side?
Else, there will be no test coverage for the `x & (-1 >> (bitwidth - c))` pattern, because it will be unfolded already.


Repository:
  rL LLVM

https://reviews.llvm.org/D52304