[PATCH] D53011: [LV] Add support for vectorizing predicated strided accesses using masked interleave-group

[Dorit Nuzman via Phabricator via llvm-commits]

dorit marked an inline comment as done.
dorit added a comment.

Comment addressed, thanks.



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:2038
+        auto *Undefs = UndefValue::get(Mask[Part]->getType());
+        auto *RepMask = createReplicatedMask(Builder, InterleaveFactor, VF);
+        Value *ShuffledMask = Builder.CreateShuffleVector(
----------------
Ayal wrote:
> One could set Undefs and RepMask once outside the "for Part" loop, using Mask[0]->getType(), and also reuse them for interleaved store group. But doing so conditional on IsMaskRequired is a bit less appealing.
Agreed. Left it as is.


https://reviews.llvm.org/D53011