[llvm] r344219 - [CMake] Temporarily remove the LLVM_ENABLE_IDE option

[Chris Bieneman via llvm-commits]

Author: cbieneman
Date: Wed Oct 10 21:06:14 2018
New Revision: 344219

URL: http://llvm.org/viewvc/llvm-project?rev=344219&view=rev
Log:
[CMake] Temporarily remove the LLVM_ENABLE_IDE option

All uses of this option have been removed, and the intent is to change the purpose and default value of this option. To prevent it from having impacts on users, this patch temporarily removes the option and purges it from CMake caches. In a few days, once this has propagated to contributors I will re-introduce the option with the new default value.

Modified:
    llvm/trunk/cmake/modules/HandleLLVMOptions.cmake

Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOptions.cmake?rev=344219&r1=344218&r2=344219&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
+++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Wed Oct 10 21:06:14 2018
@@ -868,12 +868,16 @@ else()
   set(LLVM_ENABLE_PLUGINS ON)
 endif()
 
-set(LLVM_ENABLE_IDE_default OFF)
-if (XCODE OR MSVC_IDE OR CMAKE_EXTRA_GENERATOR)
-  set(LLVM_ENABLE_IDE_default ON)
-endif()
-option(LLVM_ENABLE_IDE "Generate targets and process sources for use with an IDE"
-    ${LLVM_ENABLE_IDE_default})
+# Remove LLVM_ENABLE_IDE from the CMake cache. This is a temporary change to
+# allow CMake caches to be cleaned up so that we can change the default for this
+# option and how it is used.
+unset(LLVM_ENABLE_IDE CACHE)
+#set(LLVM_ENABLE_IDE_default OFF)
+#if (XCODE OR MSVC_IDE OR CMAKE_EXTRA_GENERATOR)
+#  set(LLVM_ENABLE_IDE_default ON)
+#endif()
+#option(LLVM_ENABLE_IDE "Generate targets and process sources for use with an IDE"
+#    ${LLVM_ENABLE_IDE_default})
 
 function(get_compile_definitions)
   get_directory_property(top_dir_definitions DIRECTORY ${CMAKE_SOURCE_DIR} COMPILE_DEFINITIONS)