[PATCH] D53054: Adapt OptTable::PrintHelp change in D51009

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 10 18:02:50 PDT 2018


MaskRay added a comment.

In https://reviews.llvm.org/D53054#1261004, @ruiu wrote:

> Please avoid llvm::formatv because StringRef and Twine work fine as well. I don't expect that the readers of the code memorizes this Python-style format string.


Sorry, https://reviews.llvm.org/rLLD344212 eliminated another instance of formatv().


Repository:
  rL LLVM

https://reviews.llvm.org/D53054





More information about the llvm-commits mailing list