[PATCH] D53111: [lit] Support the `%shared_libasan` lit substitution on Apple platforms.
Kuba (Brecka) Mracek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 10 15:57:37 PDT 2018
kubamracek added a comment.
What breaks if we switch to the absolute path on Linux?
================
Comment at: test/asan/lit.cfg:108-113
+ shared_libasan_path = os.path.join(
+ config.compiler_rt_libdir,
+ 'libclang_rt.asan_{}_dynamic.dylib'.format(
+ config.apple_platform
+ )
+ )
----------------
This is unnecessarily expanded. Fold at least the .format() call into one line (personally I'd have this whole thing on one line).
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D53111
More information about the llvm-commits
mailing list